Skip to content

Conversation

@mw2000
Copy link
Contributor

@mw2000 mw2000 commented Jan 22, 2026

Description

We now collect aggregated (by block) flashblock metrics

Fixes #153

Testing

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 22, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@mw2000 mw2000 changed the title Mw2000/fb metrics feat: Collects flashbot metrics during execution Jan 22, 2026
@mw2000 mw2000 force-pushed the mw2000/fb-metrics branch 2 times, most recently from ff26ea4 to 022b3ac Compare January 23, 2026 08:10
We now collect aggregated (by block) flashblock metrics
@mw2000 mw2000 force-pushed the mw2000/fb-metrics branch from 022b3ac to eb88521 Compare January 27, 2026 01:03
@mw2000 mw2000 marked this pull request as ready for review January 27, 2026 01:03
@mw2000 mw2000 requested a review from meyer9 January 27, 2026 01:03
Copy link
Collaborator

@meyer9 meyer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small comment about updating definitions and removing unnecessary metrics.

Reth supports flashblocks, but metrics are only available to base-reth-node for now.
@mw2000 mw2000 requested a review from meyer9 January 27, 2026 04:53
@mw2000 mw2000 changed the title feat: Collects flashbot metrics during execution feat: Collects flashblock metrics during execution Jan 27, 2026
@mw2000 mw2000 merged commit 9e38abd into main Jan 27, 2026
15 checks passed
@mw2000 mw2000 deleted the mw2000/fb-metrics branch January 27, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collect flashblock metrics during execution

4 participants